HSEARCH-1918 Fix 180 meridian crossing issue #870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolashelleringer
commented
Jul 14, 2015
nicolashelleringer
commented
Detected by non wanted double indeaxtion in Infinispan tests.
We gained tests for discrepancies between FieldBridge and
direct annotations indexing methods.
| @Field(store = Store.YES, index = Index.YES, analyze = Analyze.NO) | ||
| @FieldBridge(impl = SpatialFieldBridgeByHash.class) | ||
| @Embedded | ||
| public Coordinates getLocation() { |
There was a problem hiding this comment.
Hi just curious why are you intentionally using the explicit bridge, rather than the Spatial annotation?
@spatial(spatialMode = SpatialMode.HASH)
There was a problem hiding this comment.
I did the same way the infinispan code did it.
There was a problem hiding this comment.
Ok, thanks!
On 20 Jul 2015 17:42, "Nicolas Helleringer" notifications@github.com
wrote:
In
orm/src/test/java/org/hibernate/search/test/spatial/DoubleIndexedPOI.java
#870 (comment)
:
- @field(store = Store.YES, index = Index.YES)
- String type;
- @longitude
- @field(store = Store.YES, index = Index.YES)
- double longitude;
I did the same way the infinispan code did it.
—
Reply to this email directly or view it on GitHub
https://github.com/hibernate/hibernate-search/pull/870/files#r35001529.
|
Thanks, merged! |
|
Thanks for the quick merge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.